[webkit-reviews] review granted: [Bug 169260] Well-known variations should clamp to the values listed in the @font-face block : [Attachment 306888] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 169260: Well-known variations should clamp to the values listed in the
@font-face block
https://bugs.webkit.org/show_bug.cgi?id=169260

Attachment 306888: Patch

https://bugs.webkit.org/attachment.cgi?id=306888&action=review




--- Comment #10 from Dean Jackson <dino at apple.com> ---
Comment on attachment 306888
  --> https://bugs.webkit.org/attachment.cgi?id=306888
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306888&action=review

> Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:319
> +    uint32_t uniqueValue() const
> +    {
> +	   return minimum.rawValue() << 16 | maximum.rawValue();
> +    }
> +

Is that really unique?