[webkit-reviews] review granted: [Bug 170742] B3 -O1 should not allocateStackByGraphColoring : [Attachment 306877] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 12 09:51:06 PDT 2017

Keith Miller <keith_miller at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 170742: B3 -O1 should not allocateStackByGraphColoring

Attachment 306877: the patch


--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 306877
  --> https://bugs.webkit.org/attachment.cgi?id=306877
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306877&action=review


> Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:307
> +	       [&] (Tmp, TmpData& data) -> bool {

Why pass the Tmp if you don't use it anywhere?

More information about the webkit-reviews mailing list