[webkit-reviews] review granted: [Bug 170676] Cache small media resources in disk cache : [Attachment 306893] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 170676: Cache small media resources in disk cache
https://bugs.webkit.org/show_bug.cgi?id=170676

Attachment 306893: patch

https://bugs.webkit.org/attachment.cgi?id=306893&action=review




--- Comment #17 from Andreas Kling <akling at apple.com> ---
Comment on attachment 306893
  --> https://bugs.webkit.org/attachment.cgi?id=306893
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306893&action=review

r=me

> Source/WebCore/loader/MediaResourceLoader.h:58
> +    Vector<ResourceResponse> responsesForTesting() const { return
m_responsesForTesting; }

This could return a const Vector<ResourceResponse>& I suppose, though if it's
just for testing it matters less.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:238
> +    if (StringView(contentRange).left(6) != ASCIILiteral("bytes "))
> +	   return { };

I would write this using contentRange.startsWith().