[webkit-reviews] review granted: [Bug 170758] Modernize vector adoption : [Attachment 306882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 11 21:15:58 PDT 2017

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 170758: Modernize vector adoption

Attachment 306882: Patch


--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 306882
  --> https://bugs.webkit.org/attachment.cgi?id=306882

View in context: https://bugs.webkit.org/attachment.cgi?id=306882&action=review


>> Source/WebCore/platform/SharedBuffer.h:61
>> +	WEBCORE_EXPORT static Ref<SharedBuffer> adoptVector(Vector<char>&&);
> Seems like this could just be called create(Vector<char>&&)

👍 for create().

More information about the webkit-reviews mailing list