[webkit-reviews] review granted: [Bug 166993] Web Inspector: checkboxes in Settings screen use inappropriate layout : [Attachment 306454] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 166993: Web Inspector: checkboxes in Settings screen use inappropriate
layout
https://bugs.webkit.org/show_bug.cgi?id=166993

Attachment 306454: Patch

https://bugs.webkit.org/attachment.cgi?id=306454&action=review




--- Comment #24 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 306454
  --> https://bugs.webkit.org/attachment.cgi?id=306454
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306454&action=review

r=me.  Super awesome job!

> Source/WebInspectorUI/UserInterface/Views/SettingEditor.js:130
> +	       let keyValuePairs = [];

NIT: should be `var` not `let`

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/le
t#Temporal_dead_zone_and_errors_with_let