[webkit-reviews] review denied: [Bug 170739] Add a preference for the media resource buffering time : [Attachment 306833] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 170739: Add a preference for the media resource buffering time
https://bugs.webkit.org/show_bug.cgi?id=170739

Attachment 306833: Patch

https://bugs.webkit.org/attachment.cgi?id=306833&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 306833
  --> https://bugs.webkit.org/attachment.cgi?id=306833
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306833&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:590
> +- (double)_mediaResourceMaximumBufferingTime

I think the suffix Duration, rather than Time, would be better.

> Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:251
> +    parameters.mediaResourceMaximumBufferingTime =
Seconds(m_defaultPageGroup->preferences().mediaResourceMaximumBufferingTime());

Seems weird/wrong to have webpreferences affect WebProcess creation, since a
single web process can have web pages with different webpreferences.  It also
looks like you aren't handling the preference changing after the process is
created.