[webkit-reviews] review denied: [Bug 170739] Add a preference for the media resource buffering time : [Attachment 306833] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 11 12:04:47 PDT 2017

Sam Weinig <sam at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 170739: Add a preference for the media resource buffering time

Attachment 306833: Patch


--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 306833
  --> https://bugs.webkit.org/attachment.cgi?id=306833

View in context: https://bugs.webkit.org/attachment.cgi?id=306833&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:590
> +- (double)_mediaResourceMaximumBufferingTime

I think the suffix Duration, rather than Time, would be better.

> Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:251
> +    parameters.mediaResourceMaximumBufferingTime =

Seems weird/wrong to have webpreferences affect WebProcess creation, since a
single web process can have web pages with different webpreferences.  It also
looks like you aren't handling the preference changing after the process is

More information about the webkit-reviews mailing list