[webkit-reviews] review granted: [Bug 170644] [Cocoa] WebKit unnecessarily soft-links CorePrediction : [Attachment 306772] Link CorePrediction at build time

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted mitz at webkit.org's request for review:
Bug 170644: [Cocoa] WebKit unnecessarily soft-links CorePrediction
https://bugs.webkit.org/show_bug.cgi?id=170644

Attachment 306772: Link CorePrediction at build time

https://bugs.webkit.org/attachment.cgi?id=306772&action=review




--- Comment #16 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 306772
  --> https://bugs.webkit.org/attachment.cgi?id=306772
Link CorePrediction at build time

View in context: https://bugs.webkit.org/attachment.cgi?id=306772&action=review

>
Source/WebKit2/Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.
cpp:75
> +static inline bool isNullFunctionPointer(void* functionPointer)

This surprising function should probably have a comment explaining why it needs
inline-asm.  Also, is this something that can be lifted into WTF somewhere, as
it seems like something that could be generally useful for other weak linking.

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.h:36
> +#if PLATFORM(COCOA) && HAVE(CORE_PREDICTION)

Is it really necessary to have both predicates. Given that CORE_PREDICTION is
only on COCOA systems, it seems like just specifying it would be enough.