[webkit-reviews] review granted: [Bug 170648] test262: test262/test/annexB/language/comments/multi-line-html-close.js : [Attachment 306586] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 11 09:26:13 PDT 2017


Keith Miller <keith_miller at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 170648: test262:
test262/test/annexB/language/comments/multi-line-html-close.js
https://bugs.webkit.org/show_bug.cgi?id=170648

Attachment 306586: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=306586&action=review




--- Comment #7 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 306586
  --> https://bugs.webkit.org/attachment.cgi?id=306586
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306586&action=review

r=me.

> LayoutTests/js/parser-xml-close-comment-expected.txt:1
> +Test to ensure correct handling of --> as a single line comment when at the
beginning of a line or preceeded by a multi-line comment

Wow, I didn't know this was a thing... weird


More information about the webkit-reviews mailing list