[webkit-reviews] review granted: [Bug 170710] Activate WebRTC data channel tests for WK1 : [Attachment 306765] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 11 08:07:22 PDT 2017

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170710: Activate WebRTC data channel tests for WK1

Attachment 306765: Patch


--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 306765
  --> https://bugs.webkit.org/attachment.cgi?id=306765

View in context: https://bugs.webkit.org/attachment.cgi?id=306765&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:67
> +    ASSERT(client.factory());

Won't the m_peerConnectionFactory assignment above have crashed already if the
factory is NULL?

More information about the webkit-reviews mailing list