[webkit-reviews] review granted: [Bug 170710] Activate WebRTC data channel tests for WK1 : [Attachment 306765] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170710: Activate WebRTC data channel tests for WK1
https://bugs.webkit.org/show_bug.cgi?id=170710

Attachment 306765: Patch

https://bugs.webkit.org/attachment.cgi?id=306765&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 306765
  --> https://bugs.webkit.org/attachment.cgi?id=306765
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306765&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:67
> +    ASSERT(client.factory());

Won't the m_peerConnectionFactory assignment above have crashed already if the
factory is NULL?