[webkit-reviews] review requested: [Bug 170608] ImageDiff: Add CG implementation for new ImageDiff : [Attachment 306812] Include win changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 11 07:00:04 PDT 2017


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 170608: ImageDiff: Add CG implementation for new ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=170608

Attachment 306812: Include win changes

https://bugs.webkit.org/attachment.cgi?id=306812&action=review




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 306812

  --> https://bugs.webkit.org/attachment.cgi?id=306812&action=review

Include win changes

I've realized that the patch would break windows, because it removes the
ImageDiffCG from DRT. So, this new patch also includes the windows changed that
was going to do in a follow up patch. I have no way to test windows changes, so
I don't know whether it works or not.


More information about the webkit-reviews mailing list