[webkit-reviews] review granted: [Bug 170656] Drop Timer::startRepeating() overload taking a double : [Attachment 306769] Follow-up fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 10 21:30:47 PDT 2017


Yusuke Suzuki <utatane.tea at gmail.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 170656: Drop Timer::startRepeating() overload taking a double
https://bugs.webkit.org/show_bug.cgi?id=170656

Attachment 306769: Follow-up fix

https://bugs.webkit.org/attachment.cgi?id=306769&action=review




--- Comment #19 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 306769
  --> https://bugs.webkit.org/attachment.cgi?id=306769
Follow-up fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306769&action=review

r=me

> Source/WebCore/rendering/RenderThemeGtk.cpp:1817
> +    return 1_ms * time / 2.;

`500_ns * time` could be simpler, but the both are ok to me.


More information about the webkit-reviews mailing list