[webkit-reviews] review granted: [Bug 170672] [aarch64][Linux] m_allowScratchRegister assert hit in MacroAssemblerARM64 under B3::Air::CCallSpecial::generate() : [Attachment 306686] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 10 19:55:23 PDT 2017


Yusuke Suzuki <utatane.tea at gmail.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 170672: [aarch64][Linux] m_allowScratchRegister assert hit in
MacroAssemblerARM64 under B3::Air::CCallSpecial::generate()
https://bugs.webkit.org/show_bug.cgi?id=170672

Attachment 306686: Patch

https://bugs.webkit.org/attachment.cgi?id=306686&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 306686
  --> https://bugs.webkit.org/attachment.cgi?id=306686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306686&action=review

Nice, r=me with comment.

> Source/JavaScriptCore/b3/air/AirCCallSpecial.cpp:137
> +	   jit.call(scratchRegister);

Could you add a test to testair to ensure that the bug is fixed?


More information about the webkit-reviews mailing list