[webkit-reviews] review requested: [Bug 170362] Add SPI for handling geolocation authorization requests : [Attachment 306764] Patch v2.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 10 18:07:25 PDT 2017


David Quesada <david_quesada at apple.com> has asked  for review:
Bug 170362: Add SPI for handling geolocation authorization requests
https://bugs.webkit.org/show_bug.cgi?id=170362

Attachment 306764: Patch v2.1

https://bugs.webkit.org/attachment.cgi?id=306764&action=review




--- Comment #14 from David Quesada <david_quesada at apple.com> ---
Created attachment 306764

  --> https://bugs.webkit.org/attachment.cgi?id=306764&action=review

Patch v2.1

Addressed Alex's feedback - changed WebGeolocationPosition::create to a Ref<>,
compiled out the API tests on Mac, and (attempted to) fix EWS errors.


More information about the webkit-reviews mailing list