[webkit-reviews] review granted: [Bug 170696] Have parseRevisionProperty use default repo name as the buildbot key. : [Attachment 306749] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Kocsen Chung
<kocsen_chung at apple.com>'s request for review:
Bug 170696: Have parseRevisionProperty use default repo name as the buildbot
key.
https://bugs.webkit.org/show_bug.cgi?id=170696

Attachment 306749: Patch

https://bugs.webkit.org/attachment.cgi?id=306749&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 306749
  --> https://bugs.webkit.org/attachment.cgi?id=306749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306749&action=review

> Tools/ChangeLog:9
> +	   buildobt data. That is no longer necessary as we can make a safe
assumption

buildobt => Buildbot

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
uildbotIteration.js:208
> +	       var key = repositoryName;

Instead of default initializing these variables and then overwriting them for
OpenSiurce I suggest that we leave them hninitialized here and remove the "else
if" For Internal.