[webkit-reviews] review granted: [Bug 170530] CachedImage should stop decoding images with unknown types : [Attachment 306739] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 170530: CachedImage should stop decoding images with unknown types
https://bugs.webkit.org/show_bug.cgi?id=170530

Attachment 306739: Patch

https://bugs.webkit.org/attachment.cgi?id=306739&action=review




--- Comment #14 from Tim Horton <thorton at apple.com> ---
Comment on attachment 306739
  --> https://bugs.webkit.org/attachment.cgi?id=306739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306739&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:2503
> +		5550CB421E955E3C00111AA0 /* ImageDefs.h in Headers */ = {isa =
PBXBuildFile; fileRef = 5550CB411E955E3C00111AA0 /* ImageDefs.h */; settings =
{ATTRIBUTES = (Private, ); }; };

I don't love the name. There is no predecent for -Defs. Can we go with -Types
instead, which we have a bunch of?

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:-180
> -    // Ragnaros yells: TOO SOON! You have awakened me TOO SOON, Executus!

Awwww, this is a sad removal.