[webkit-reviews] review denied: [Bug 169077] Disable JavaScript JIT in non-audible background tabs : [Attachment 306440] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 10 06:14:33 PDT 2017


Filip Pizlo <fpizlo at apple.com> has denied  review:
Bug 169077: Disable JavaScript JIT in non-audible background tabs
https://bugs.webkit.org/show_bug.cgi?id=169077

Attachment 306440: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=306440&action=review




--- Comment #7 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 306440
  --> https://bugs.webkit.org/attachment.cgi?id=306440
Proposed patch

I'm not sure any of this is a good idea. 

What if the background tab starts doing computation?  The llint can be 10,000x
slower in extreme cases. That's a lot of wasted power. It could even be a spin
when you go back to that tab. 

I don't think we want this.


More information about the webkit-reviews mailing list