[webkit-reviews] review canceled: [Bug 170655] [JSC] Enable JSRunLoopTimer for JSCOnly and Windows : [Attachment 306622] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 10 00:46:07 PDT 2017

Yusuke Suzuki <utatane.tea at gmail.com> has canceled Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 170655: [JSC] Enable JSRunLoopTimer for JSCOnly and Windows

Attachment 306622: Patch


--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 306622
  --> https://bugs.webkit.org/attachment.cgi?id=306622

View in context: https://bugs.webkit.org/attachment.cgi?id=306622&action=review

Thanks, I'll update the patch.

>> Source/JavaScriptCore/jsc.cpp:3891
>> +	RunLoop::initializeMainRunLoop();
> Do we really need this? JS timers use RunLoop::current() not main(). If we
need it, then we can remove WTF::initializeMainThread(); because
initializeMainRunLoop already initializes the main thread.

Right, it is not necessary. Dropped.

>> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:190
>> +	m_timer.startOneShot(s_decade);
> RunLoop::Timer::start() already calls stop().

Nice, dropped.

>> Source/JavaScriptCore/runtime/JSRunLoopTimer.h:85
>> +	RunLoop::Timer<JSRunLoopTimer> m_timer;
> Yes, I think we could adopt this implementation at least for non cocoa based
ports. I think when we added support for heap timer, RunLoop was still in

Yeah, non cocoa based ports, I'll change to use this RunLoop::Timer in the
subsequent patch.
This patch paves the way for that.

More information about the webkit-reviews mailing list