[webkit-reviews] review granted: [Bug 170658] [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes : [Attachment 306636] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 170658: [WK2] Add infrastructure to perform actions after an asynchronous
position information request finishes
https://bugs.webkit.org/show_bug.cgi?id=170658

Attachment 306636: Patch

https://bugs.webkit.org/attachment.cgi?id=306636&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 306636
  --> https://bugs.webkit.org/attachment.cgi?id=306636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306636&action=review

Very cool.

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:374
> +    EXPECT_LT([NSDate timeIntervalSinceReferenceDate] - startTime, 1);

Did this actually fail before? I thought the timeout was 500ms. Also I hope
this isn't flaky on contended bots... we'll see.