[webkit-reviews] review granted: [Bug 170656] Drop Timer::startRepeating() overload taking a double : [Attachment 306626] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 170656: Drop Timer::startRepeating() overload taking a double
https://bugs.webkit.org/show_bug.cgi?id=170656

Attachment 306626: Patch

https://bugs.webkit.org/attachment.cgi?id=306626&action=review




--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 306626
  --> https://bugs.webkit.org/attachment.cgi?id=306626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306626&action=review

r=me with nits

> Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:91
> +	   m_requestFrameTimer.startRepeating(Seconds { 1. /
m_frameRequestRate.value() });

I like `1_s / m_frameRequestRate.value()` rather.

> Source/WebCore/page/Frame.cpp:124
> +const Seconds scrollFrequency { 1000 / 60. };

Ditto. I think `1000_s / 60` is more descriptive.

> Source/WebCore/page/WheelEventTestTrigger.cpp:63
> +	   m_testTriggerTimer.startRepeating(Seconds { 1. / 60 });

Ditto.

> Source/WebCore/platform/cocoa/ScrollController.mm:389
> +    m_snapRubberbandTimer.startRepeating(Seconds { 1. / 60 });

Ditto.

> Source/WebCore/platform/cocoa/ScrollController.mm:565
> +    m_scrollSnapTimer.startRepeating(Seconds { 1. / 60 });

Ditto.

> Source/WebCore/rendering/RenderMarquee.cpp:171
> +    m_timer.startRepeating(Seconds { speed() * 0.001 });

I think `1_ms * speed()` is better.

> Source/WebCore/rendering/RenderMarquee.cpp:233
> +	       m_timer.startRepeating(Seconds { speed() * 0.001 });

Ditto.