[webkit-reviews] review granted: [Bug 170646] Remove use of strcpy from JSC : [Attachment 306593] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 8 19:25:58 PDT 2017


Mark Lam <mark.lam at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 170646: Remove use of strcpy from JSC
https://bugs.webkit.org/show_bug.cgi?id=170646

Attachment 306593: Patch

https://bugs.webkit.org/attachment.cgi?id=306593&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 306593
  --> https://bugs.webkit.org/attachment.cgi?id=306593
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306593&action=review

r=me with ChangeLog comment fixed.

> Source/JavaScriptCore/ChangeLog:10
> +	   Replace the use of strcpy with strlcpy as strcpy keeps
> +	   on tripping various analyser warnings even though its
> +	   trivially safe in this case.

Your comment needs to be updated.


More information about the webkit-reviews mailing list