[webkit-reviews] review granted: [Bug 170112] Add CoreAudioCaptureSource. : [Attachment 306407] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 170112: Add CoreAudioCaptureSource.
https://bugs.webkit.org/show_bug.cgi?id=170112

Attachment 306407: Patch

https://bugs.webkit.org/attachment.cgi?id=306407&action=review




--- Comment #15 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 306407
  --> https://bugs.webkit.org/attachment.cgi?id=306407
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306407&action=review

> Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm:99
> +    if (active != enabled) {

Nit: an return early would be more idiomatic of WebKit style.

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:45
> +
> +

Nit: extra blank line.

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:165
> +    // Set the format of the data we supply to the output stream.
> +

Nit: this isn't necessary.