[webkit-reviews] review granted: [Bug 170605] [MediaStream iOS] Update muted state when interrupted : [Attachment 306572] Updated patch.

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 170605: [MediaStream iOS] Update muted state when interrupted
https://bugs.webkit.org/show_bug.cgi?id=170605

Attachment 306572: Updated patch.

https://bugs.webkit.org/attachment.cgi?id=306572&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 306572
  --> https://bugs.webkit.org/attachment.cgi?id=306572
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=306572&action=review

> Source/WebCore/ChangeLog:19
> +	   call notifyMutedObservers because the session has already stopped
running.

Is there a case where captureSessionIsRunningDidChange will be called for the
session to start/restart?

> Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:278
> +	   if (m_muted != m_isRunning) {

Shouldn't it be "if (m_muted == m_isRunning)" since we are doing "m_muted =
!m_isRunning;" inside the if statement.

> Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:279
> +	       // Update muted state without generating a call to
StartProducingData/StopProducingData.

Not sure this comment helps. Maybe the ChangeLog is good enough?