[webkit-reviews] review granted: [Bug 170577] A synchronous DecodingOptions should be compatible with any asynchronous sizeForDrawing DecodingOptions : [Attachment 306442] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 7 17:32:53 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 170577: A synchronous DecodingOptions should be compatible with any
asynchronous sizeForDrawing DecodingOptions
https://bugs.webkit.org/show_bug.cgi?id=170577

Attachment 306442: Patch

https://bugs.webkit.org/attachment.cgi?id=306442&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 306442
  --> https://bugs.webkit.org/attachment.cgi?id=306442
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306442&action=review

> Source/WebCore/ChangeLog:8
> +	   Test: fast/images/async-image-background-image-repeated.html

This should go below the paragraph below.

> Source/WebCore/platform/graphics/DecodingOptions.h:76
> +	   // Comparing DedocingOptions with isAsynchronous() should not
happen.

"DedocingOptions"


More information about the webkit-reviews mailing list