[webkit-reviews] review granted: [Bug 170495] Add fallback fonts to video captions stylesheet. : [Attachment 306253] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 170495: Add fallback fonts to video captions stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=170495

Attachment 306253: Patch

https://bugs.webkit.org/attachment.cgi?id=306253&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 306253
  --> https://bugs.webkit.org/attachment.cgi?id=306253
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306253&action=review

> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:87
> +#define kCTFontCascadeListAttribute getkCTFontCascadeListAttribute()

Why are we soft linking CoreText? It's available on all platforms which also
have MACaptionAppearanceCopyFontDescriptorForStyle().

> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:437
> +    auto cascadeList = adoptCF(CTFontDescriptorCopyAttribute(font.get(),
kCTFontCascadeListAttribute));

Put the static_cast<CFArrayRef>() here rather than on line 440.

> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:441
> +	   auto fontCascadeName =
adoptCF(CTFontDescriptorCopyAttribute(fontCascade, kCTFontNameAttribute));

Ditto.