[webkit-reviews] review granted: [Bug 170579] Add a PriorityQueue class : [Attachment 306530] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 7 13:02:21 PDT 2017
Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 170579: Add a PriorityQueue class
https://bugs.webkit.org/show_bug.cgi?id=170579
Attachment 306530: Patch
https://bugs.webkit.org/attachment.cgi?id=306530&action=review
--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 306530
--> https://bugs.webkit.org/attachment.cgi?id=306530
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=306530&action=review
r=me
> Source/JavaScriptCore/wasm/WasmWorklist.cpp:184
> + while (!m_queue.isEmpty()) {
> + QueueElement element = m_queue.dequeue();
> if (&element.plan->vm() == &vm) {
> element.plan->cancel();
> - return IterateResult::DropAndContinue;
> + continue;
> }
You need to rebase. This is no longer the code.
> Source/WTF/wtf/PriorityQueue.h:39
> +//
Please remove this.
> Source/WTF/wtf/PriorityQueue.h:138
> + IsHigherPriority isHigherPriority;
I still don't quite understand why we need this, instead of something akin to
HashTraits. Maybe file a bug to do this? It's unfortunate to make this class
use more memory than needed. The only use of this class ATM will be a struct
with no field members. It could just as easily be some abstract API.
More information about the webkit-reviews
mailing list