[webkit-reviews] review granted: [Bug 170601] REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr : [Attachment 306510] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 170601: REGRESSION (r214553): Allow layout-tests to be run from Xcode
without re-directing stdout, stdin and stderr
https://bugs.webkit.org/show_bug.cgi?id=170601

Attachment 306510: Patch

https://bugs.webkit.org/attachment.cgi?id=306510&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 306510
  --> https://bugs.webkit.org/attachment.cgi?id=306510
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306510&action=review

> Tools/TestRunnerShared/IOSLayoutTestCommunication.cpp:54
>      int port = atoi(getenv("PORT"));

Why not use portFromEnvironment here?