[webkit-reviews] review granted: [Bug 170553] [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup() : [Attachment 306432] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 170553: [GTK] Misplaced right click menu on web page due to deprecated
gtk_menu_popup()
https://bugs.webkit.org/show_bug.cgi?id=170553

Attachment 306432: Patch

https://bugs.webkit.org/attachment.cgi?id=306432&action=review




--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 306432
  --> https://bugs.webkit.org/attachment.cgi?id=306432
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306432&action=review

Please do test under Wayland before committing.

> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:127
> +    const GdkRectangle position = { menuPosition.x(), menuPosition.y(), 
requisition.width, requisition.height };

Got an extra space (two spaces) before requisition.width here

> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:128
> +    gtk_menu_popup_at_rect(GTK_MENU(m_popup),
gtk_widget_get_window(m_webView) , &position, GDK_GRAVITY_NORTH_WEST,
GDK_GRAVITY_NORTH_WEST, event);

Got an extra space before the comma here