[webkit-reviews] review granted: [Bug 170587] [JSC] Change --debug option to --debugger : [Attachment 306467] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 6 22:04:58 PDT 2017


Keith Miller <keith_miller at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 170587: [JSC] Change --debug option to --debugger
https://bugs.webkit.org/show_bug.cgi?id=170587

Attachment 306467: Patch

https://bugs.webkit.org/attachment.cgi?id=306467&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 306467
  --> https://bugs.webkit.org/attachment.cgi?id=306467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review

r=me with comment.

> Tools/Scripts/run-jsc:43
>  my $debug = 0;

nit: I would change this to $debugger.


More information about the webkit-reviews mailing list