[webkit-reviews] review denied: [Bug 169714] [jsc] Add missing MacroAssemblerMIPS::or32() implementation : [Attachment 304573] Patch

[bugzilla-daemon at webkit.org]

Guillaume Emont <guijemont at igalia.com> has denied Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 169714: [jsc] Add missing MacroAssemblerMIPS::or32() implementation
https://bugs.webkit.org/show_bug.cgi?id=169714

Attachment 304573: Patch

https://bugs.webkit.org/attachment.cgi?id=304573&action=review




--- Comment #4 from Guillaume Emont <guijemont at igalia.com> ---
Comment on attachment 304573
  --> https://bugs.webkit.org/attachment.cgi?id=304573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304573&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:481
> +		   m_assembler.addu(dataTempRegister, dataTempRegister,
immTempRegister);

Wow! I did not pay attention when doing that. This obviously should be an
orInsn not an addu! Will also fix in the new version. The fact that this
mistake was not obvious when looking at test results makes me think that this
code path (or the whole function) might never be used.