[webkit-reviews] review granted: [Bug 170222] [JSC][MIPS][DFG] Use x86 generic HasOwnProperty : [Attachment 306343] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 6 03:03:17 PDT 2017


Yusuke Suzuki <utatane.tea at gmail.com> has granted Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 170222: [JSC][MIPS][DFG] Use x86 generic HasOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=170222

Attachment 306343: Patch

https://bugs.webkit.org/attachment.cgi?id=306343&action=review




--- Comment #10 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 306343
  --> https://bugs.webkit.org/attachment.cgi?id=306343
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306343&action=review

r=me with comment

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1385
> +#if CPU(X86) && USE(JSVALUE32_64) || CPU(MIPS)

`#if (CPU(X86) || CPU(MIPS)) && USE(JSVALUE32_64)` is better.


More information about the webkit-reviews mailing list