[webkit-reviews] review granted: [Bug 170523] Add support for test262 JavaScriptCore tests : [Attachment 306339] Proposed patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 170523: Add support for test262 JavaScriptCore tests
https://bugs.webkit.org/show_bug.cgi?id=170523

Attachment 306339: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=306339&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 306339
  --> https://bugs.webkit.org/attachment.cgi?id=306339
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306339&action=review

Looks sane to me.

> Tools/ChangeLog:12
> +	   (RunTest262Tests.countFailures): method ot count the failures.

method => Method
ot => to

> Tools/ChangeLog:13
> +	   (Test262Factory): Added Test262 Factory class.

Factory => factory

> Tools/ChangeLog:16
> +	   (RunTest262TestsTest.assertResults): helper method.

helper => Helper

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:337
> +	   logText = cmd.logs['stdio'].getText()

' => "