[webkit-reviews] review granted: [Bug 170494] REGRESSION fix bad isWasm() test by ensuring proper Wasm callee bit pattern : [Attachment 306309] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 170494: REGRESSION fix bad isWasm() test by ensuring proper Wasm callee bit
pattern
https://bugs.webkit.org/show_bug.cgi?id=170494

Attachment 306309: patch

https://bugs.webkit.org/attachment.cgi?id=306309&action=review




--- Comment #15 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 306309
  --> https://bugs.webkit.org/attachment.cgi?id=306309
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306309&action=review

r=me, nice.

> Source/JavaScriptCore/interpreter/CalleeBits.h:66
> +#if ENABLE(WEBASSEMBLY)
> +	   return (bitwise_cast<uintptr_t>(m_ptr) & TagWasmMask) ==
TagBitsWasm;
> +#else
> +	   return false;
> +#endif

I think this if-def is not necessary.