[webkit-reviews] review granted: [Bug 170496] [iOS] DDQueryOffset is the wrong size in Public SDK builds : [Attachment 306262] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 4 23:23:31 PDT 2017

Alexey Proskuryakov <ap at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 170496: [iOS] DDQueryOffset is the wrong size in Public SDK builds

Attachment 306262: Patch


--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 306262
  --> https://bugs.webkit.org/attachment.cgi?id=306262

View in context: https://bugs.webkit.org/attachment.cgi?id=306262&action=review


> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=170496

https://bugs.webkit.org/show_bug.cgi?id=161967 ?

> Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:120
> +static_assert(sizeof(DDQueryOffset) == 8, "DDQueryOffset is defined to be 8
bytes in the Public SDK build.");

The message doesn't sound quite right - the assert can potentially fail in
non-public build too (and that's a good thing).

More information about the webkit-reviews mailing list