[webkit-reviews] review requested: [Bug 16531] Web Inspector: Show all headers in the Request Headers section of the Resource details sidebar : [Attachment 306244] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 16531: Web Inspector: Show all headers in the Request Headers section of
the Resource details sidebar
https://bugs.webkit.org/show_bug.cgi?id=16531

Attachment 306244: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=306244&action=review




--- Comment #19 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 306244

  --> https://bugs.webkit.org/attachment.cgi?id=306244&action=review

[PATCH] Proposed Fix

Some things I have to test:

1. Is it possible to send a request with duplicate header? if so I need a test
for that
2. I have concerns about potential performance issues:
  - this makes a HTTPHeaderMap for every request and serializes between the
NetworkProcess and WebProcess (by putting it in NetworkLoadMetrics)
  - I suspect this will be normally be small but it could be large and if so I
want to make sure we don't negatively impact load performance