[webkit-reviews] review granted: [Bug 170486] Canvas is tainted when painting a video with MediaStreamTrack : [Attachment 306235] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 4 19:39:11 PDT 2017

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170486: Canvas is tainted when painting a video with MediaStreamTrack

Attachment 306235: Patch


--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 306235
  --> https://bugs.webkit.org/attachment.cgi?id=306235

View in context: https://bugs.webkit.org/attachment.cgi?id=306235&action=review

> LayoutTests/http/tests/media/media-stream/resources/getUserMedia-helper.js:32
> +    evalAndLog('video.srcObject = mediaStream');

Looks like you changed the test but not the results:

> video.src = window.URL.createObjectURL(mediaStream)

URL.createObjectURL(mediastream) has been deprecated (see
https://github.com/w3c/mediacapture-main/issues/404#issuecomment-271521028 and
https://webkit.org/b/167518) so this form is better.

More information about the webkit-reviews mailing list