[webkit-reviews] review granted: [Bug 170485] B3::fixSSA() needs a tune-up : [Attachment 306230] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 170485: B3::fixSSA() needs a tune-up
https://bugs.webkit.org/show_bug.cgi?id=170485

Attachment 306230: the patch

https://bugs.webkit.org/attachment.cgi?id=306230&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 306230
  --> https://bugs.webkit.org/attachment.cgi?id=306230
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306230&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   changes to make this phase run faster. This is a ~7% wasm -O1
compile time progression.

awesome

> Source/WTF/wtf/IndexSparseSet.h:47
> +    typedef T EntryType;

style nit: can be "using".

> Source/WTF/wtf/IndexSparseSet.h:57
> +    static T create(T entry)
> +    {
> +	   return entry;
> +    }
> +    
> +    static T key(T entry)
> +    {
> +	   return entry;
> +    }

maybe these should take "const T& entry"?

> Source/WTF/wtf/IndexSparseSet.h:62
> +    typedef KeyValuePair<KeyType, ValueType> EntryType;

ditto on "using".