[webkit-reviews] review granted: [Bug 170477] Web Inspector: RTL: fix alignment of "truncated call stack" message : [Attachment 306215] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 4 16:18:17 PDT 2017


Devin Rousso <webkit at devinrousso.com> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 170477: Web Inspector: RTL: fix alignment of "truncated call stack" message
https://bugs.webkit.org/show_bug.cgi?id=170477

Attachment 306215: Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=306215&action=review




--- Comment #5 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 306215
  --> https://bugs.webkit.org/attachment.cgi?id=306215
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306215&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css:66
> +    margin-left: var(--truncated-call-frames-margin-start);
> +    margin-right: var(--truncated-call-frames-margin-end);

NIT: I prefer to follow the shorthand order when using longhand properties.

margin-right: var(--truncated-call-frames-margin-end);
margin-left: var(--truncated-call-frames-margin-start);


More information about the webkit-reviews mailing list