[webkit-reviews] review granted: [Bug 170481] Add JF Bastien as reviewer 🎉 : [Attachment 306221] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 4 15:42:55 PDT 2017


Mark Lam <mark.lam at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 170481: Add JF Bastien as reviewer 🎉
https://bugs.webkit.org/show_bug.cgi?id=170481

Attachment 306221: patch

https://bugs.webkit.org/attachment.cgi?id=306221&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 306221
  --> https://bugs.webkit.org/attachment.cgi?id=306221
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306221&action=review

r=me with fixes.  For future reference, you don't need a bug and a review for
this change.  A ChangeLog entry is needed though.

> Tools/ChangeLog:3
> +	   Add JF Bastien as reviewer ð

Can you remove the non-ascii char?

> Tools/Scripts/webkitpy/common/config/contributors.json:-5831
> -}
>  \ No newline at end of file
> +}
> -- 

Revert this please.


More information about the webkit-reviews mailing list