[webkit-reviews] review granted: [Bug 170459] Don't need to Air::reportUsedRegisters for wasm at -O1 : [Attachment 306181] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 170459: Don't need to Air::reportUsedRegisters for wasm at -O1
https://bugs.webkit.org/show_bug.cgi?id=170459

Attachment 306181: the patch

https://bugs.webkit.org/attachment.cgi?id=306181&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 306181
  --> https://bugs.webkit.org/attachment.cgi?id=306181
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306181&action=review

r=me

> Source/JavaScriptCore/b3/B3StackmapGenerationParams.h:63
> +    // NOTE: This will report bogus information if you did
proc.setNeedsUsedRegisters(false).

Can we make it crash, at least in debug builds?

> Source/JavaScriptCore/b3/air/AirLiveness.h:42
> +	   SuperSamplerScope samplingScope(false);
> +	   WTF::Liveness<Adapter>::compute();

Is the reason for this change just so you can time it?