[webkit-reviews] review granted: [Bug 169743] [JSC] Generate TemplateObjects at linking time : [Attachment 304674] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 4 10:57:53 PDT 2017


Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 169743: [JSC] Generate TemplateObjects at linking time
https://bugs.webkit.org/show_bug.cgi?id=169743

Attachment 304674: Patch

https://bugs.webkit.org/attachment.cgi?id=304674&action=review




--- Comment #5 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 304674
  --> https://bugs.webkit.org/attachment.cgi?id=304674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304674&action=review

r=me with a question.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:932
> +    scope.release();

Why do you need the manually release the scope here?


More information about the webkit-reviews mailing list