[webkit-reviews] review denied: [Bug 170418] Web Inspector: Reorder Debugger tab sidebar panels: Scope Chain, Resource, Probes : [Attachment 306140] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 170418: Web Inspector: Reorder Debugger tab sidebar panels: Scope Chain,
Resource, Probes
https://bugs.webkit.org/show_bug.cgi?id=170418

Attachment 306140: Patch

https://bugs.webkit.org/attachment.cgi?id=306140&action=review




--- Comment #9 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 306140
  --> https://bugs.webkit.org/attachment.cgi?id=306140
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306140&action=review

> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:154
> +		   WebInspector.detailsSidebar.addSidebarPanel(sidebarPanel,
(a, b) => {

Wouldn't we know the index it needs inserted at? You would be better off adding
a inserSidebarPanel function that takes an index. No need to sort the array for
one item insert when the order is known already.

> Source/WebInspectorUI/UserInterface/Views/Sidebar.js:63
> +    addSidebarPanel(sidebarPanel, comparator)

The index implementation you add below can be used for a new
insertSidebarPanel. And you can make addSidebarPanel use it to reduce
duplication.