[webkit-reviews] review requested: [Bug 170430] TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf : [Attachment 306135] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 3 16:10:07 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 170430: TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
https://bugs.webkit.org/show_bug.cgi?id=170430

Attachment 306135: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=306135&action=review




--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 306135

  --> https://bugs.webkit.org/attachment.cgi?id=306135&action=review

[PATCH] Proposed Fix

Tested with:

    $ rm -rf $build/TestWebKitAPI*
    $ run-api-tests WebKit1.CancelLoadFromResourceLoadDelegate
CancelLoading.CancelFontSubresource
    Running build-api-tests
    PASS CancelLoading.CancelFontSubresource
    PASS WebKit1.CancelLoadFromResourceLoadDelegate

This will make it harder to just open
TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html from the source
directory, because "Ahem.ttf" is not in that directory but we use the one in
TestWebKitAPI/Tests/WebKit2/Ahem.ttf. I think thats fine, because what really
matters is run-api-tests.


More information about the webkit-reviews mailing list