[webkit-reviews] review granted: [Bug 169301] Japanese fonts in vertical text should support synthesized italics : [Attachment 306106] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 3 15:12:00 PDT 2017
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 169301: Japanese fonts in vertical text should support synthesized italics
https://bugs.webkit.org/show_bug.cgi?id=169301
Attachment 306106: Patch
https://bugs.webkit.org/attachment.cgi?id=306106&action=review
--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 306106
--> https://bugs.webkit.org/attachment.cgi?id=306106
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=306106&action=review
> Source/WebCore/platform/graphics/FontCascadeFonts.cpp:305
> + // If there is a baked-in rotated glyph, we will use it unless
syntheticOblique is set. If
> + // synthetic oblique is set, we fall back to the horizontal glyph.
This allows us to guarantee that vertical fonts without
isTextOrientationFallback() set
> + // contain CJK characters only and thus we can get the oblique slant
correct.
Awkward comment wrapping.
More information about the webkit-reviews
mailing list