[webkit-reviews] review granted: [Bug 170397] run-safari should support launching with custom language and locale : [Attachment 306094] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 170397: run-safari should support launching with custom language and locale
https://bugs.webkit.org/show_bug.cgi?id=170397

Attachment 306094: Patch

https://bugs.webkit.org/attachment.cgi?id=306094&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 306094
  --> https://bugs.webkit.org/attachment.cgi?id=306094
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306094&action=review

OK. I'm still unsure if this won't cause more confusion than good though.

> Tools/Scripts/webkitdirs.pm:-2179
> -  -g|--guard-malloc		       Enable Guard Malloc (OS X only)

Surely this still doesn't work on Linux or Windows.

> Tools/Scripts/webkitdirs.pm:2180
> +  --lang=LANGUAGE		       Use a specific language instead of
system language.

Why abbreviate?

> Tools/Scripts/webkitdirs.pm:2182
> +  --locale=LOCALE		       Useg a specific locale instead of the
system region.

Typo: Useg.

Also, these won't work on Linux either.