[webkit-reviews] review granted: [Bug 170404] [MediaStream] Video doesn't render in fullscreen on iOS : [Attachment 306086] Proposed patch.

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 170404: [MediaStream] Video doesn't render in fullscreen on iOS
https://bugs.webkit.org/show_bug.cgi?id=170404

Attachment 306086: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=306086&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 306086
  --> https://bugs.webkit.org/attachment.cgi?id=306086
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=306086&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStrea
mAVFObjC.h:-56
> -#if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)

PLATFORM(COCOA)?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStrea
mAVFObjC.mm:1112
> +    scheduleDeferredTask([this] {

Should we protect ´this'?
If so, should the m_backgroundLayer check be done here?