[webkit-reviews] review granted: [Bug 170391] Implement PromiseDeferredTimer for non CF based ports : [Attachment 306055] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 2 11:05:58 PDT 2017
Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 170391: Implement PromiseDeferredTimer for non CF based ports
https://bugs.webkit.org/show_bug.cgi?id=170391
Attachment 306055: Patch
https://bugs.webkit.org/attachment.cgi?id=306055&action=review
--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 306055
--> https://bugs.webkit.org/attachment.cgi?id=306055
Patch
It looks OK to me, but I wonder if the separate implementation for CF is really
necessary. If it really is, then I'd expect RunLoop to be implemented in terms
of CFRunLoop....
More information about the webkit-reviews
mailing list