[webkit-reviews] review granted: [Bug 170274] [GCrypt] Implement AES_KW support : [Attachment 305846] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 170274: [GCrypt] Implement AES_KW support
https://bugs.webkit.org/show_bug.cgi?id=170274

Attachment 305846: Patch

https://bugs.webkit.org/attachment.cgi?id=305846&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 305846
  --> https://bugs.webkit.org/attachment.cgi?id=305846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305846&action=review

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:36
> +#include <pal/crypto/gcrypt/Handle.h>
> +#include <pal/crypto/gcrypt/Utilities.h>

:(

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:65
> +    Vector<uint8_t> output(data.size() + 8);

Correct, but it needs a short comment to explain the + 8 (e.g. "On encryption
the provided output buffer must be 64 bit (8 byte) larger than the input
buffer" from
https://www.gnupg.org/documentation/manuals/gcrypt/Available-cipher-modes.html)
.

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:72
> +    return WTFMove(output);

:(

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:100
> +    Vector<uint8_t> output(data.size() - 8);

Comment

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:107
> +    return WTFMove(output);

:(