[webkit-reviews] review requested: [Bug 43239] Support for HTML Media Capture API : [Attachment 294315] Proposed patch V2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 10 17:12:11 PST 2016
Eric Carlson <eric.carlson at apple.com> has asked for review:
Bug 43239: Support for HTML Media Capture API
https://bugs.webkit.org/show_bug.cgi?id=43239
Attachment 294315: Proposed patch V2
https://bugs.webkit.org/attachment.cgi?id=294315&action=review
--- Comment #10 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 294315 did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/WKUserMediaCaptureDeviceAuthorizerIOS.mm:0:
No copyright message found. You should have a line: "Copyright [year]
<Copyright Owner>" [legal/copyright] [5]
ERROR:
Source/WebKit2/UIProcess/ios/WKUserMediaCaptureDeviceAuthorizerIOS.mm:11:
Found header this file implements before WebCore config.h. Should be: config.h,
primary header, blank line, and then alphabetically sorted.
[build/include_order] [4]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against
check-webkit-style.
More information about the webkit-reviews
mailing list