[webkit-reviews] review granted: [Bug 144938] WebCrypto: RSASSA-PKCS1-v1_5 generated keys can not be exported : [Attachment 264956] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 6 14:08:06 PST 2015
Alexey Proskuryakov <ap at webkit.org> has granted Scott Valentine
<svalentine at ikayzo.com>'s request for review:
Bug 144938: WebCrypto: RSASSA-PKCS1-v1_5 generated keys can not be exported
https://bugs.webkit.org/show_bug.cgi?id=144938
Attachment 264956: Patch
https://bugs.webkit.org/attachment.cgi?id=264956&action=review
--- Comment #17 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 264956 did not pass style-queue:
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:99:
CryptoAlgorithmRSAES_PKCS1_v1_5::importKey is incorrectly named. Don't use
underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 14 files
If any of these errors are false positives, please file a bug against
check-webkit-style.
More information about the webkit-reviews
mailing list