[webkit-reviews] review granted: [Bug 142513] 8-bit version of weakCompareAndSwap() can cause an infinite loop : [Attachment 248308] take 4: fixed missing volatile

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 9 19:12:55 PDT 2015


Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 142513: 8-bit version of weakCompareAndSwap() can cause an infinite loop
https://bugs.webkit.org/show_bug.cgi?id=142513

Attachment 248308: take 4: fixed missing volatile

https://bugs.webkit.org/attachment.cgi?id=248308&action=review




--- Comment #11 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 248308
  --> https://bugs.webkit.org/attachment.cgi?id=248308
take 4: fixed missing volatile

View in context: https://bugs.webkit.org/attachment.cgi?id=248308&action=review

> Source/WTF/wtf/Atomics.h:-316
> -    // Make sure that this load is always issued and never optimized away.

I should probably restore this comment.


More information about the webkit-reviews mailing list